I am trying to figure out if the new effect is implemented as intended.

For example a base unit of Carroburg Greatswords has a weapon strength of 35 and my rank 5 Carroburg Greatswords has a weapon strength of 38

I would have expected them to have a weapon strength of 43 if it is 5 ranks leading to a 25% increase off of the 35 base value.

It may be that I am not understanding the description correctly and it calculated differently than what I expect or it could be a bug. 

I do know that the "Best of the Empire"  skill is currently bugged so that it doesn't give the +2 to recruitment rank as intended so I would not be surprised if there were other issues in the various traits.

And yes, I really did buy the new DLC just to play yet another Reikland campaign

Thanks, for any assistance, been playing the series since TW Warhammer 2, but never posted on the forums before.

Upon further inspection I have discovered that the bonus towards weapon/missile strength seems to increase "Base" strength, but not armor piercing strength so armor piercing units like the greatswords don't really get that much of a buff from it.